lkml.org 
[lkml]   [2013]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 1/2] [PATCH] mm: Save soft-dirty bits on swapped pages
On Mon, Aug 05, 2013 at 10:58:35AM +0800, Wanpeng Li wrote:
> >
> >pte_to_swp_entry is passed orig_pte by vaule, not a pointer
> >so although pte_to_swp_entry clear out _PTE_SWP_SOFT_DIRTY, it does it in local-copy.
> >So orig_pte is never changed.
>
> Ouch! Thanks for pointing out. ;-)
>
> Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>

Yeah, it's a bit tricky. Thanks.


\
 
 \ /
  Last update: 2013-08-05 08:01    [W:0.066 / U:9.136 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site