lkml.org 
[lkml]   [2013]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] mips/kvm: Improve code formatting in arch/mips/kvm/kvm_locore.S
Hi David,

On 01/08/13 21:22, David Daney wrote:
> From: David Daney <david.daney@cavium.com>
>
> No code changes, just reflowing some comments and consistently using
> tabs and spaces. Object code is verified to be unchanged.
>
> Signed-off-by: David Daney <david.daney@cavium.com>
> Acked-by: Ralf Baechle <ralf@linux-mips.org>


> + /* Put the saved pointer to vcpu (s1) back into the DDATA_LO Register */

git am detects a whitespace error here ("space before tab in indent").
It's got spaces before and after the tab actually.

> /* load the guest context from VCPU and return */

this comment could have it's indentation fixed too

Otherwise, for all 3 patches:

Reviewed-by: James Hogan <james.hogan@imgtec.com>

Thanks
James



\
 
 \ /
  Last update: 2013-08-05 16:01    [W:0.070 / U:0.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site