lkml.org 
[lkml]   [2013]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging: wlags49_h2: fixed 80 line character and white space issue in ap_h2.c Fixed various coding style warnings found by the checkpatch.pl tool
Hello Evan,

When reformatting the array containing the firmware data it may be easier
to use 8 bytes per row. It is currently it is 16 bytes per row
(overrunning the 80 characters/line) and this just means cutting each row
exactly in half. In your first proposal it was completely reformatted to
an odd 11 bytes per row which makes comparison with the original during
review much harder and it is also easier to make mistakes.

Kind regards,

Henk.



\
 
 \ /
  Last update: 2013-08-04 18:01    [W:0.027 / U:3.816 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site