lkml.org 
[lkml]   [2013]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] Staging: olpc_dcon: replace some magic numbers
From
On Sun, Aug 4, 2013 at 1:14 AM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> On Sat, Aug 03, 2013 at 10:44:35PM +0200, Jens Frederich wrote:
>> @@ -126,7 +127,7 @@ static int dcon_bus_stabilize(struct dcon_priv *dcon, int is_powered_down)
>> power_up:
>> if (is_powered_down) {
>> x = 1;
>> - x = olpc_ec_cmd(0x26, (unsigned char *)&x, 1, NULL, 0);
>> + x = olpc_ec_cmd(EC_DCON_POWER_MODE, (u8 *)&x, 1, NULL, 0);
> ^^^^^^^^
> You didn't introduce this but using "x" as the inbuf here messy.
> It should be char instead of an int. The code won't work on big
> endian systems. I know this hardware is only available on little
> endian systems and that's why it's not a bug. It's just an ugly
> thing to do.
>

Hello Dan, you're right. It doesn't matter whether the current
hardware is little or big endian. The driver should be able to
support both. I will fix it soon.

thanks,
Jens


\
 
 \ /
  Last update: 2013-08-04 22:41    [W:0.041 / U:1.168 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site