Messages in this thread | | | Date | Fri, 30 Aug 2013 10:38:25 -0700 | Subject | Re: linux-next: build failure after merge of the aio tree | From | Linus Torvalds <> |
| |
On Fri, Aug 30, 2013 at 12:55 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote: > - aio_ring_file->f_path.dentry->d_count, > + aio_ring_file->f_path.dentry->d_lockref.count,
This is wrong. If you really want the dentry count (which I doubt, I don't see why this code would care _even_ just for a debug printout), you should use
d_count(aio_ring_file->f_dentry)
instead these days. That will get the count from the right place, regardless of any lockref issues or anything else (and f_dentry may be the "old" way to get the dentry, but it's still supported and unlikely to go away. No point in writing out "f_path.dentry" unless you *want* to be aware of the fact that f_path has both a dentry and a mnt member - but most people really don't care about the mnt information).
Linus
| |