Messages in this thread | | | Date | Fri, 30 Aug 2013 18:02:15 +0200 | From | Peter Zijlstra <> | Subject | Re: [PATCH 1/4] perf, x86: Avoid checkpointed counters causing excessive TSX aborts v4 |
| |
On Wed, Aug 21, 2013 at 04:47:23PM -0700, Andi Kleen wrote: > @@ -1224,6 +1240,15 @@ again: > x86_pmu.drain_pebs(regs); > } > > + /* > + * To avoid spurious interrupts with perf stat always reset checkpointed > + * counters. > + * > + * XXX move somewhere else. > + */ > + if (cpuc->events[2] && event_is_checkpointed(cpuc->events[2])) > + status |= (1ULL << 2); > + > for_each_set_bit(bit, (unsigned long *)&status, X86_PMC_IDX_MAX) { > struct perf_event *event = cpuc->events[bit]; >
I'm sure I commented on that XXX thing..
Yep, right here:
http://marc.info/?l=linux-kernel&m=137638980210140
Sup?
| |