lkml.org 
[lkml]   [2013]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 4/4] ASoC: kirkwood: change kirkwood-i2s to mvebu-pcm-audio and DT doc
On Wed, Jul 31, 2013 at 08:18:58AM +0200, Jean-Francois Moine wrote:
> diff --git a/sound/soc/kirkwood/kirkwood-i2s.c b/sound/soc/kirkwood/kirkwood-i2s.c
> index 9844010..4f817a2 100644
> --- a/sound/soc/kirkwood/kirkwood-i2s.c
> +++ b/sound/soc/kirkwood/kirkwood-i2s.c
> @@ -25,7 +25,7 @@
>
> #include "kirkwood.h"
>
> -#define DRV_NAME "kirkwood-i2s"
> +#define DRV_NAME "mvebu-pcm-audio"

This breaks non-DT users of this driver. The device in arch/arm/mach-kirkwood
is left as "kirkwood-i2s" but the platform device is now called something
different.

> static struct of_device_id kirkwood_i2s_of_match[] = {
> - { .compatible = "marvell,kirkwood-i2s" },
> + { .compatible = "marvell,mvebu-pcm-audio" },

You've only just introduced "marvell,kirkwood-i2s" in the previous patch.
Why introduce something and then immediately change its name? This makes
no sense what so ever.


\
 
 \ /
  Last update: 2013-08-03 16:01    [W:0.037 / U:8.508 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site