lkml.org 
[lkml]   [2013]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Subjectregulator: s2mps11: Question about the code updating ramp_delay setting
From
Date
Hi Yadwinder,
The code updating ramp_delay setting looks wrong to me.

Current code:
return regmap_update_bits(rdev->regmap, ramp_reg,
ramp_val << ramp_shift, 1 << ramp_shift);
I'd expect something like below:
return regmap_update_bits(rdev->regmap, ramp_reg,
ramp_mask << ramp_shift,
ramp_val << ramp_shift);
I don't have the datasheet so I don't know the correct ramp_mask setting
here. Can you check if this needs fix?

Thanks,
Axel




\
 
 \ /
  Last update: 2013-08-03 11:41    [W:0.022 / U:1.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site