Messages in this thread | | | From | Laurent Pinchart <> | Subject | Re: [PATCH 1/5] mfd: asic3: Remove .set_pwr() callback | Date | Thu, 29 Aug 2013 16:59:11 +0200 |
| |
Hi Chris,
On Thursday 29 August 2013 07:42:26 Kevin Hilman wrote: > On Wed, Aug 28, 2013 at 12:51 AM, Laurent Pinchart wrote: > > On Wednesday 28 August 2013 08:41:26 Lee Jones wrote: > >> > > Since 3af9d15 "mmc: tmio-mmc: Remove .set_pwr() callback from > >> > > platform data", .set_pwr() callback is removed from platform data. > >> > > Thus, .set_pwr() is not used anymore. Also, this patch fixes > >> > > the following build error and warning. > >> > > > >> > > drivers/mfd/asic3.c:724:2: error: unknown field 'set_pwr' specified > >> > > in initializer drivers/mfd/asic3.c:724:2: warning: initialization > >> > > makes integer from pointer without a cast [enabled by default] > >> > > drivers/mfd/asic3.c:724:2: warning: (near initialization for > >> > > 'asic3_mmc_data.capabilities' [enabled by default] > >> > > >> > My bad, it looks like I've overlooked a few users of the .set_pwr() > >> > field > >> > > >> > :-/ Sorry about that. > >> > >> <snip> > >> > >> > I don't think blindly removing the function is the right fix, as it > >> > seems to be needed. Looking at the whole series, I believe we should > >> > just revert 3af9d15 "mmc: tmio-mmc: Remove .set_pwr() callback from > >> > platform data" instead. > >> > >> No need to revert it, as it's not in Mainline yet. Just request for it > >> to be removed from Chris' tree. > > > > I spupose it depends on whether Chris has provided a stable branch with > > the patch included. I'm fine with both, the commit just needs to be undone > > one way or another. > > Any progress on this? linux-next builds are still failing for the > following defconfigs because of this removal:
Chris, could you please drop 3af9d15 "mmc: tmio-mmc: Remove .set_pwr() callback from platform data" from your tree or revert it ?
> Failed defconfigs: > arm-magician_defconfig > arm-eseries_pxa_defconfig > > Errors: > > arm-magician_defconfig > drivers/mfd/asic3.c:724:2: error: unknown field 'set_pwr' specified in > initializer > > arm-eseries_pxa_defconfig > drivers/mfd/t7l66xb.c:146:2: error: unknown field 'set_pwr' specified > in initializer > drivers/mfd/tc6387xb.c:123:2: error: unknown field 'set_pwr' specified > in initializer > drivers/mfd/tc6393xb.c:381:2: error: unknown field 'set_pwr' specified > in initializer
-- Regards,
Laurent Pinchart
| |