lkml.org 
[lkml]   [2013]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 33/35] power: use dev_get_platdata()
On Tue, Aug 13, 2013 at 12:00:39PM +0300, Dan Carpenter wrote:
> > > > Use the wrapper function for retrieving the platform data instead of
> > > > accessing dev->platform_data directly.
> > >
> > > Um.. what is the benefit or rationale of this patch?
> >
> > CC'ed Joe Perches, Dan Carpenter
> >
> > Hi Anton Vorontsov,
> >
> > Usually, using the wrapper function makes the code simpler.
> > Also, it make the code more readable.
>
> Since people are asking my opinion, then yes using
> dev_get_platdata() as intended is better than open coding. It's a
> coding standard thing.

I don't see any immediate benefit of applying this patch... It does not
fix anything now or in the near future (or we are about to add something
into dev_get_platdata() wrapper, or get rid of dev.platform_data member?
Any plans for this? Then it should be in the commit message.)

Without any plans to actually use the wrapper the patch is just a churn
[that might result into patch conflicts that I'll have to deal with], so
I'll refrain from applying it.

Thanks,

Anton


\
 
 \ /
  Last update: 2013-08-28 04:21    [W:1.345 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site