Messages in this thread | | | Subject | Re: [PATCH RESEND V3 net-next 2/3] net: huawei_cdc_ncm: Introduce the huawei_cdc_ncm driver | From | Joe Perches <> | Date | Mon, 26 Aug 2013 14:05:55 -0700 |
| |
On Mon, 2013-08-26 at 16:58 -0400, David Miller wrote: > From: Joe Perches <joe@perches.com> > Date: Mon, 26 Aug 2013 13:45:13 -0700 > > > I think the premise of local variable > > declaration by line length is flawed. > > I disagree. > > > It can't work when local variables are > > dependent on initialization order as > > above. > > Move the initialization below the declarations.
So all initializations should be on separate lines from declarations?
ick.
It's possible, but it doubles the associated line count and I still think it's a very dubious premise/practice/style.
As a general rule, it's I suppose OK, but as a hardened rule, it's like most all hard rules. It's made to be broken.
| |