Messages in this thread | | | Subject | Re: [PATCH RESEND V3 net-next 2/3] net: huawei_cdc_ncm: Introduce the huawei_cdc_ncm driver | From | Joe Perches <> | Date | Mon, 26 Aug 2013 13:45:13 -0700 |
| |
On Mon, 2013-08-26 at 16:31 -0400, David Miller wrote: > From: Enrico Mioso <mrkiko.rs@gmail.com> [] > > + int ret = 0; > > + struct usbnet *usbnet_dev = usb_get_intfdata(intf); > > + struct huawei_cdc_ncm_state *drvstate = (void *)&usbnet_dev->data; > > + struct cdc_ncm_ctx *ctx = drvstate->ctx; > > + bool callsub = (intf == ctx->control && drvstate->subdriver && drvstate->subdriver->resume); /* should we call subdriver's resume? ? */ > > Likewise, and order local function variable declarations by line > length, longest to shortest.
I think the premise of local variable declaration by line length is flawed.
It can't work when local variables are dependent on initialization order as above.
int ret; could be moved down below callsub if really desired though.
| |