Messages in this thread | | | Date | Mon, 26 Aug 2013 19:19:38 +0800 | From | Chen Gang <> | Subject | Re: [PATCH] h8300/kernel/setup.c: add "linux/initrd.h" to pass compiling |
| |
On 08/26/2013 07:08 PM, Geert Uytterhoeven wrote: > On Mon, Aug 26, 2013 at 1:06 PM, Chen Gang <gang.chen@asianux.com> wrote: >> On 08/26/2013 07:00 PM, Geert Uytterhoeven wrote: >>> On Mon, Aug 26, 2013 at 12:31 PM, Chen Gang <gang.chen@asianux.com> wrote: >>>> --- a/arch/h8300/kernel/setup.c >>>> +++ b/arch/h8300/kernel/setup.c >>>> @@ -47,6 +47,9 @@ >>>> #include <asm/regs267x.h> >>>> #endif >>>> >>>> +#if defined(CONFIG_BLK_DEV_INITRD) >>> >>> Why have you added the #ifdef? >>> >> >> The related code is below (maybe we need add additional related >> comments in the patch for it ?). >> >> in arch/h8300/kernel/setup.c >> >> 94 void __init setup_arch(char **cmdline_p) >> 95 { >> 96 int bootmap_size; >> 97 >> 98 memory_start = (unsigned long) &_ramstart; >> 99 >> 100 /* allow for ROMFS on the end of the kernel */ >> 101 if (memcmp((void *)memory_start, "-rom1fs-", 8) == 0) { >> 102 #if defined(CONFIG_BLK_DEV_INITRD) >> 103 initrd_start = memory_start; >> 104 initrd_end = memory_start += be32_to_cpu(((unsigned long *) (memory_start))[2]); >> 105 #else >> 106 memory_start += be32_to_cpu(((unsigned long *) memory_start)[2]); >> 107 #endif >> 108 } > > Sure, it's used conditionally. But it doesn't harm to always include it. > That means less #ifdefs in the code. >
Hmm... I feel, add "#ifdefs" can make the code more clearer (consistent with the "#ifdefs" 'for initrd_start' and 'end').
For C code readers, more code doesn't mean more complex, if it can make things clearer after add some more lines (and be sure of no negative effect with performance), normally I prefer to add some more lines.
And this file has already had an area for all "#ifdefs include", I just add it in this area, so at least, it can mach this file well, is it ?
;-)
Thanks.
> Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > >
-- Chen Gang
| |