Messages in this thread | | | From | Chris Ball <> | Subject | Re: [PATCH] mmc: omap_hsmmc: clear status flags before starting a new command | Date | Sun, 25 Aug 2013 15:41:49 -0400 |
| |
Hi,
On Sun, Aug 25 2013, Balaji T K wrote: > On Saturday 29 June 2013 11:55 AM, Francesco Lavra wrote: >> Commit 1f6b9fa40e76fffaaa0b3bd6a0bfdcf1cdc06efa consolidated writes to >> the STAT register in one location, moving them from omap_hsmmc_do_irq() >> to omap_hsmmc_irq(). This move has the unwanted side effect that the >> controller status flags are potentially cleared after a new command has >> been started as a consequence of reading the previous status flags. >> This means that if the new command changes the status flags before the >> IRQ routine returns, those flags may be cleared without handling the >> event which asserted them, and thus missing the event. >> Move the writing of the STAT register back in omap_hsmmc_do_irq(), >> before handling the status flags which generated the interrupt. >> >> Signed-off-by: Francesco Lavra <francescolavra.fl@gmail.com> > > Reviewed and Tested-by: Balaji T K <balajitk@ti.com>
Thanks, pushed to mmc-next for 3.12.
- Chris. -- Chris Ball <cjb@laptop.org> <http://printf.net/>
| |