Messages in this thread | | | Date | Sat, 24 Aug 2013 11:55:45 +0800 | From | Jisheng Zhang <> | Subject | Re: [PATCH 4/4] pinctrl: mvebu: add missing iounmap |
| |
Hi Linus and Ezequiel,
On Fri, 23 Aug 2013 13:19:26 -0700 Ezequiel Garcia <ezequiel.garcia@free-electrons.com> wrote:
> On Fri, Aug 23, 2013 at 08:06:02PM +0200, Linus Walleij wrote: > > On Thu, Aug 22, 2013 at 3:22 PM, Ezequiel Garcia > > <ezequiel.garcia@free-electrons.com> wrote: > > > On Thu, Aug 22, 2013 at 08:46:51PM +0800, Jisheng Zhang wrote: > > >> Add missing iounmap to prove error path and remove path > > >> > > >> Signed-off-by: Jisheng Zhang <jszhang@marvell.com> > > >> --- > > >> drivers/pinctrl/mvebu/pinctrl-mvebu.c | 24 +++++++++++++++++------- > > >> 1 file changed, 17 insertions(+), 7 deletions(-) > > > > > > How about using devm_ioremap_resource() instead? > > > > Yeah that's the right solution, Jisheng can you fix this? > > > > I think he already did that, there's a v2 floating around > with such change. I plan to give it a test, maybe tomorrow, > if I can find some spare time. >
Yep. Here is the V2
http://lists.infradead.org/pipermail/linux-arm-kernel/2013-August/194072.html
Thank you for your help, Jisheng
| |