Messages in this thread | | | Date | Fri, 23 Aug 2013 17:19:26 -0300 | From | Ezequiel Garcia <> | Subject | Re: [PATCH 4/4] pinctrl: mvebu: add missing iounmap |
| |
On Fri, Aug 23, 2013 at 08:06:02PM +0200, Linus Walleij wrote: > On Thu, Aug 22, 2013 at 3:22 PM, Ezequiel Garcia > <ezequiel.garcia@free-electrons.com> wrote: > > On Thu, Aug 22, 2013 at 08:46:51PM +0800, Jisheng Zhang wrote: > >> Add missing iounmap to prove error path and remove path > >> > >> Signed-off-by: Jisheng Zhang <jszhang@marvell.com> > >> --- > >> drivers/pinctrl/mvebu/pinctrl-mvebu.c | 24 +++++++++++++++++------- > >> 1 file changed, 17 insertions(+), 7 deletions(-) > > > > How about using devm_ioremap_resource() instead? > > Yeah that's the right solution, Jisheng can you fix this? >
I think he already did that, there's a v2 floating around with such change. I plan to give it a test, maybe tomorrow, if I can find some spare time.
Regards, -- Ezequiel García, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |