Messages in this thread Patch in this message | | | Date | Fri, 23 Aug 2013 15:49:39 +0900 | From | Joonsoo Kim <> | Subject | Re: [PATCH 04/16] slab: remove nodeid in struct slab |
| |
On Thu, Aug 22, 2013 at 05:51:58PM +0000, Christoph Lameter wrote: > On Thu, 22 Aug 2013, Joonsoo Kim wrote: > > > @@ -1099,8 +1098,7 @@ static void drain_alien_cache(struct kmem_cache *cachep, > > > > static inline int cache_free_alien(struct kmem_cache *cachep, void *objp) > > { > > - struct slab *slabp = virt_to_slab(objp); > > - int nodeid = slabp->nodeid; > > + int nodeid = page_to_nid(virt_to_page(objp)); > > struct kmem_cache_node *n; > > struct array_cache *alien = NULL; > > int node; > > virt_to_page is a relatively expensive operation. How does this affect > performance?
Previous code, that is virt_to_slab(), already do virt_to_page(). So this doesn't matter at all.
Thanks.
> > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
| |