lkml.org 
[lkml]   [2013]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] scsi: fix the build warning
    From
    On Thu, Aug 22, 2013 at 9:55 AM, Joe Perches <joe@perches.com> wrote:
    > On Wed, 2013-08-21 at 21:25 -0400, Martin K. Petersen wrote:
    >> >>>>> "Joe" == Joe Perches <joe@perches.com> writes:
    >>
    >> Joe> I don't get this build warning in the first place and I think the
    >> Joe> scsi_debug file is quite old and probably doesn't need to be
    >> Joe> changed at all.
    >>
    >> guard isn't a boolean, it selects the checksum algorithm used.
    >
    > OK, maybe this then...
    > ---
    > drivers/scsi/scsi_debug.c | 2 +-
    > 1 file changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
    > index cb4fefa..6fc2831 100644
    > --- a/drivers/scsi/scsi_debug.c
    > +++ b/drivers/scsi/scsi_debug.c
    > @@ -3312,7 +3312,7 @@ static int __init scsi_debug_init(void)
    > return -EINVAL;
    > }
    >
    > - if (scsi_debug_guard > 1) {
    > + if (scsi_debug_guard < 0 || scsi_debug_guard > 1) {
    I don't think that it can fix that issue.
    > printk(KERN_ERR "scsi_debug_init: guard must be 0 or 1\n");
    > return -EINVAL;
    > }
    >
    >



    --
    Regards,

    Zhi Yong Wu


    \
     
     \ /
      Last update: 2013-08-22 04:21    [W:3.491 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site