lkml.org 
[lkml]   [2013]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dma: sh: remove unnecessary platform_set_drvdata()
On Wed, Aug 21, 2013 at 06:45:35PM +0900, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure. Thus, it is not needed to manually clear the
> device driver data to NULL.

Acked-by: Simon Horman <horms+renesas@verge.net.au>

Vinod, could you take this?

>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/dma/sh/shdma.c | 3 ---
> drivers/dma/sh/sudmac.c | 2 --
> 2 files changed, 5 deletions(-)
>
> diff --git a/drivers/dma/sh/shdma.c b/drivers/dma/sh/shdma.c
> index 211e2f1..208de0f 100644
> --- a/drivers/dma/sh/shdma.c
> +++ b/drivers/dma/sh/shdma.c
> @@ -873,7 +873,6 @@ rst_err:
> pm_runtime_put(&pdev->dev);
> pm_runtime_disable(&pdev->dev);
>
> - platform_set_drvdata(pdev, NULL);
> shdma_cleanup(&shdev->shdma_dev);
> eshdma:
> if (dmars)
> @@ -917,8 +916,6 @@ static int sh_dmae_remove(struct platform_device *pdev)
> iounmap(shdev->dmars);
> iounmap(shdev->chan_reg);
>
> - platform_set_drvdata(pdev, NULL);
> -
> synchronize_rcu();
> kfree(shdev);
>
> diff --git a/drivers/dma/sh/sudmac.c b/drivers/dma/sh/sudmac.c
> index c494417..23fffc8 100644
> --- a/drivers/dma/sh/sudmac.c
> +++ b/drivers/dma/sh/sudmac.c
> @@ -393,7 +393,6 @@ static int sudmac_probe(struct platform_device *pdev)
> chan_probe_err:
> sudmac_chan_remove(su_dev);
>
> - platform_set_drvdata(pdev, NULL);
> shdma_cleanup(&su_dev->shdma_dev);
>
> return err;
> @@ -407,7 +406,6 @@ static int sudmac_remove(struct platform_device *pdev)
> dma_async_device_unregister(dma_dev);
> sudmac_chan_remove(su_dev);
> shdma_cleanup(&su_dev->shdma_dev);
> - platform_set_drvdata(pdev, NULL);
>
> return 0;
> }
> --
> 1.7.10.4
>
>


\
 
 \ /
  Last update: 2013-08-22 03:01    [W:0.315 / U:0.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site