lkml.org 
[lkml]   [2013]   [Aug]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRE: [patch] mm, thp: count thp_fault_fallback anytime thp fault fails
On Wed, 21 Aug 2013, Kirill A. Shutemov wrote:

> David Rientjes wrote:
> > Currently, thp_fault_fallback in vmstat only gets incremented if a
> > hugepage allocation fails. If current's memcg hits its limit or the page
> > fault handler returns an error, it is incorrectly accounted as a
> > successful thp_fault_alloc.
> >
> > Count thp_fault_fallback anytime the page fault handler falls back to
> > using regular pages and only count thp_fault_alloc when a hugepage has
> > actually been faulted.
> >
> > Signed-off-by: David Rientjes <rientjes@google.com>
>
> It's probably a good idea, but please make the behaviour consistent in
> do_huge_pmd_wp_page() and collapse path, otherwise it doesn't make sense.
>

The collapse path has no fallback, the allocation either succeeds or it
fails.


\
 
 \ /
  Last update: 2013-08-22 01:21    [W:0.122 / U:0.216 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site