| Date | Tue, 20 Aug 2013 23:37:02 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH 9/9] tcm_qla2xxx: Add special case for COMPARE_AND_WRITE data_direction |
| |
On Tue, Aug 20, 2013 at 08:08:00PM +0000, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger <nab@daterainc.com> > > Add a special case for COMPARE_AND_WRITE for the reverse data direction > mapping used for pci_map_sg() + friends.
A low level driver is an even worse place to hardcode a specific cdb opcode. As written before this should be done by a flag on the command.
Also it might make sense to lift this helper to get a dma direction from a command into common code.
|