| Date | Tue, 20 Aug 2013 21:47:45 +0200 | From | Sebastian Hesselbarth <> | Subject | Re: [RFC 02/17] ARM: call clk_of_init from time_init |
| |
On 08/20/2013 05:46 PM, Stephen Warren wrote: > On 08/19/2013 08:04 PM, Sebastian Hesselbarth wrote: >> Most DT ARM machs require common clock providers initialized before timers. >> Currently, arch/arm machs use .init_time to call clk_of_init right before >> clocksource_of_init. This prevents to remove that hook and use the default >> hook instead. clk_of_init now checks for multiple calls to it, so add >> the call to ARM arch time_init by default. > > Some SoCs call this function in .init_irq() rather than .init_time(). > Perhaps we adjust this patch to do that instead. That way, we can > presumably get rid of patch 1/17 since we can eliminate any duplicate > calls, and adjust patch 14/17 (Tegra board file) to remove its custom > call to of_clock_init(NULL)?
Currently as of -next from yesterday, only tegra is requiring clocks that early, while others are fine with them close to timers. I really have no strong opinion on that. That decision should rather be made by those with a far more complete insight of the consequences than I have.
Sebastian
|