Messages in this thread | | | Date | Tue, 20 Aug 2013 14:59:18 -0400 (EDT) | From | Alan Stern <> | Subject | Re: [PATCH 1/2] usb: fix cleanup after failure in hub_configure() |
| |
On Tue, 20 Aug 2013, Krzysztof Mazur wrote:
> > Why bother with a separate jump label? Just set maxchild to 0 whenever > > a failure occurs. > > > > Initially I had just straightforward "dev->maxchild = 0;" after fail, > but I changed that to simplify the second patch and be able to > use goto fail: > > ret = usb_hub_create_port_device(hub, i + 1); > if (ret < 0) { > dev_err(hub->intfdev, > "couldn't create port%d device.\n", i + 1); > hdev->maxchild = i; > goto fail; > } > > and avoid "return ret" here or something like > > if (hdev->maxchild == hub->descriptor->bNbrPorts) > hdev->maxchild = 0; > > in the fail path.
The second patch can either clean up the port devices by hand, or else jump to a new label after the line that sets maxchild to 0.
Alan Stern
| |