Messages in this thread | | | Date | Tue, 20 Aug 2013 16:37:22 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH] kernel: user_namespace: always set the return parameter 'new_cred' when call unshare_userns() successfully. |
| |
On 08/20, Serge Hallyn wrote: > > Quoting Chen Gang (gang.chen@asianux.com): > > When unshare_userns() succeed, recommend to always set the return > > parameter which may be used by caller. > > > > The caller has rights to call it with 'new_cred' uninitialized, if > > succeed, the caller can assume the 'new_cred' has been initialized. > > But the only existing caller (sys_unshare) does in fact initialize it to > NULL. So while this patch does no harm, is it necessary?
Agreed.
Plus, with this patch unshare_userns() becomes "inconsistent" compared to other unshare_ helpers.
Oleg.
| |