Messages in this thread | | | Date | Fri, 2 Aug 2013 11:35:29 +0300 | From | Tomi Valkeinen <> | Subject | Re: [PATCHv3 1/3] video: mxsfb: fix color settings for 18bit data bus and 32bpp |
| |
On 01/08/13 11:40, Maxime Ripard wrote: > From: Hector Palacios <hector.palacios@digi.com> > > For a combination of 18bit LCD data bus width and a color > mode of 32bpp, the driver was setting the color mapping to > rgb666, which is wrong, as the color in memory realy has an > rgb888 layout. > > This patch also removes the setting of flag CTRL_DF24 that > makes the driver dimiss the upper 2 bits when handling 32/24bpp > colors in a diplay with 18bit data bus width. This flag made > true color images display wrong in such configurations. > > Finally, the color mapping rgb666 has also been removed as nobody > is using it and high level applications like Qt5 cannot work > with it either. > > Reference: https://lkml.org/lkml/2013/5/23/220 > Signed-off-by: Hector Palacios <hector.palacios@digi.com> > Acked-by: Juergen Beisert <jbe@pengutronix.de> > Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > drivers/video/mxsfb.c | 26 -------------------------- > 1 file changed, 26 deletions(-)
This one is labeled as "fix". Should it got to v3.11?
Tomi
[unhandled content-type:application/pgp-signature] | |