Messages in this thread | | | Date | Fri, 2 Aug 2013 18:25:54 +0200 | From | Frederic Weisbecker <> | Subject | Re: [PATCH 6/8] perf: Account freq events per cpu |
| |
On Thu, Aug 01, 2013 at 04:40:05PM +0200, Peter Zijlstra wrote: > On Thu, Aug 01, 2013 at 04:21:11PM +0200, Frederic Weisbecker wrote: > > > > Yeah, just go with a single global state for now.. > > > > > > The perf default is to create inherited counter, which are per cpu > > > anyway. So we'll not loose much. > > > > So you mean that I keep the per cpu state when event->cpu != -1 and also have > > a global counter for the others. Right? > > No, only a single global counter. The fact that perf, by default, > creates a counter per cpu, means that there's little effective > difference between a single global counter and per-cpu counters.
Good point! I just included that in the changelog.
Thanks.
| |