lkml.org 
[lkml]   [2013]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 04/23] SCSI: qla2xxx: Properly set the tagging for commands.
    Date
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Saurav Kashyap <saurav.kashyap@qlogic.com>

    commit c3ccb1d7cf4c4549151876dd37c0944a682fd9e1 upstream.

    This fixes a regression where Xyratex controllers and disks were lost by the
    driver:

    https://bugzilla.kernel.org/show_bug.cgi?id=59601

    Reported-by: Jack Hill <jackhill@jackhill.us>
    Signed-off-by: Saurav Kashyap <saurav.kashyap@qlogic.com>
    Signed-off-by: Giridhar Malavali <giridhar.malavali@qlogic.com>
    Signed-off-by: James Bottomley <JBottomley@Parallels.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/scsi/qla2xxx/qla_iocb.c | 11 +++++++++--
    1 file changed, 9 insertions(+), 2 deletions(-)

    --- a/drivers/scsi/qla2xxx/qla_iocb.c
    +++ b/drivers/scsi/qla2xxx/qla_iocb.c
    @@ -422,6 +422,8 @@ qla2x00_start_scsi(srb_t *sp)
    __constant_cpu_to_le16(CF_SIMPLE_TAG);
    break;
    }
    + } else {
    + cmd_pkt->control_flags = __constant_cpu_to_le16(CF_SIMPLE_TAG);
    }

    /* Load SCSI command packet. */
    @@ -1099,11 +1101,11 @@ qla24xx_build_scsi_crc_2_iocbs(srb_t *sp
    fcp_cmnd->task_attribute = TSK_ORDERED;
    break;
    default:
    - fcp_cmnd->task_attribute = 0;
    + fcp_cmnd->task_attribute = TSK_SIMPLE;
    break;
    }
    } else {
    - fcp_cmnd->task_attribute = 0;
    + fcp_cmnd->task_attribute = TSK_SIMPLE;
    }

    cmd_pkt->fcp_rsp_dseg_len = 0; /* Let response come in status iocb */
    @@ -1305,7 +1307,12 @@ qla24xx_start_scsi(srb_t *sp)
    case ORDERED_QUEUE_TAG:
    cmd_pkt->task = TSK_ORDERED;
    break;
    + default:
    + cmd_pkt->task = TSK_SIMPLE;
    + break;
    }
    + } else {
    + cmd_pkt->task = TSK_SIMPLE;
    }

    /* Load SCSI command packet. */



    \
     
     \ /
      Last update: 2013-08-02 14:01    [W:4.282 / U:0.384 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site