Messages in this thread | | | Date | Fri, 2 Aug 2013 11:17:33 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 1/2] mfd: ab8500-gpadc: add CONFIG_PM_RUNTIME to runtime_suspend/runtime_resume |
| |
On Fri, 02 Aug 2013, Jingoo Han wrote:
> Add CONFIG_PM_RUNTIME to runtime_suspend/runtime_resume functions > to fix the build warnings when CONFIG_PM_RUNTIME is not selected. > This is because runtime PM callbacks defined by SET_RUNTIME_PM_OPS > are only used when the CONFIG_PM_RUNTIME is enabled. > > drivers/mfd/ab8500-gpadc.c:870:12: warning: 'ab8500_gpadc_runtime_suspend' defined but not used [-Wunused-function] > drivers/mfd/ab8500-gpadc.c:878:12: warning: 'ab8500_gpadc_runtime_resume' defined but not used [-Wunused-function] > > Signed-off-by: Jingoo Han <jg1.han@samsung.com> > --- > drivers/mfd/ab8500-gpadc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c > index 7623e91..77c616f 100644 > --- a/drivers/mfd/ab8500-gpadc.c > +++ b/drivers/mfd/ab8500-gpadc.c > @@ -867,6 +867,7 @@ static void ab8500_gpadc_read_calibration_data(struct ab8500_gpadc *gpadc) > gpadc->cal_data[ADC_INPUT_VBAT].offset); > } > > +#ifdef CONFIG_PM_RUNTIME > static int ab8500_gpadc_runtime_suspend(struct device *dev) > { > struct ab8500_gpadc *gpadc = dev_get_drvdata(dev); > @@ -885,6 +886,7 @@ static int ab8500_gpadc_runtime_resume(struct device *dev) > dev_err(dev, "Failed to enable vtvout LDO: %d\n", ret); > return ret; > } > +#endif > > static int ab8500_gpadc_suspend(struct device *dev) > {
Looks sensible. I wonder why we haven't caught these before.
I guess we always enable PM_SLEEP.
Applied until Linus tells me otherwise.
-- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |