Messages in this thread | | | Date | Mon, 19 Aug 2013 13:25:10 -0700 | Subject | Re: commit 94fc5d9: chromium-sandbox core dumped | From | Linus Torvalds <> |
| |
On Mon, Aug 19, 2013 at 11:48 AM, Emmanuel Benisty <benisty.e@gmail.com> wrote: > > The following commit breaks chromium on my machine ("proc: > return on proc_readdir error") > > Chromium breaks with: > > [269:269:0819/203839:FATAL:zygote_host_impl_linux.cc(195)] Check > failed: pid_0. Did not find zygote process (using sandbox binary > /usr/lib/chromium/chromium-sandbox) > Aborted (core dumped)
Hmm. I think that Richard's patch is correct, but looking at all this, it looks like the return value of proc_readdir() is broken.
The comment above proc_readdir_de() says
* This returns non-zero if at EOF, so that the /proc * root directory can use this and check if it should * continue with the <pid> entries..
which is exactly what it should do. But the *code* does no such thing, and instead always returns 0, breaking Richards patch.
I suspect that last "return 0" at the end should be "return 1". Does that fix things for you? Untested.
Al? It looks to me like commit f0c3b5093add ("[readdir] convert procfs") messed up when it changed proc_readdir_de() to not have all those "goto out" things any more...
Linus
| |