Messages in this thread Patch in this message | | | From | Julia Lawall <> | Subject | [PATCH] mmc: jz4740: fix devm_ioremap_resource error detection code | Date | Mon, 19 Aug 2013 18:00:09 +0200 |
| |
From: Julia Lawall <Julia.Lawall@lip6.fr>
devm_ioremap_resource returns an ERR_PTR value, not NULL, on failure.
A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ expression e,e1; statement S; @@
*e = devm_ioremap_resource(...); if (!e1) S
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
--- drivers/mmc/host/jz4740_mmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/jz4740_mmc.c b/drivers/mmc/host/jz4740_mmc.c index 0308c9f..30589c8 100644 --- a/drivers/mmc/host/jz4740_mmc.c +++ b/drivers/mmc/host/jz4740_mmc.c @@ -783,8 +783,8 @@ static int jz4740_mmc_probe(struct platform_device* pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); host->base = devm_ioremap_resource(&pdev->dev, res); - if (!host->base) { - ret = -EBUSY; + if (IS_ERR(host->base)) { + ret = PTR_ERR(host->base); dev_err(&pdev->dev, "Failed to ioremap base memory\n"); goto err_free_host; }
| |