Messages in this thread | | | Date | Mon, 19 Aug 2013 14:02:50 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH 1/7] PCI: tegra: replace devm_request_and_ioremap by devm_ioremap_resource |
| |
On Mon, Aug 19, 2013 at 01:20:35PM +0200, Julia Lawall wrote: > From: Julia Lawall <Julia.Lawall@lip6.fr> > > Use devm_ioremap_resource instead of devm_request_and_ioremap. > > This was done using the semantic patch > scripts/coccinelle/api/devm_ioremap_resource.cocci > > Error-handling code was manually removed from the associated calls to > platform_get_resource. > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> > > --- > The first block of modified code is followed by a call to > devm_request_mem_region for pcie->cs with no associated ioremap. Should > ioremap be used in this case as well?
No. The pcie->cs resource is 256 MiB so it's challenging to map it at once. Furthermore it requires a non-linear mapping so we do it on demand.
> drivers/pci/host/pci-tegra.c | 29 +++++++++-------------------- > 1 file changed, 9 insertions(+), 20 deletions(-)
Tested-by: Thierry Reding <treding@nvidia.com> Acked-by: Thierry Reding <treding@nvidia.com>
Bjorn, how do you want to handle patches to the Tegra PCIe driver in the future? Do you want me to prepare a branch and pull from that or would you rather just take simple patches?
Thierry [unhandled content-type:application/pgp-signature] | |