lkml.org 
[lkml]   [2013]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/27] drivers/dma: don't check resource with devm_ioremap_resource
On Tue, Jul 23, 2013 at 08:01:37PM +0200, Wolfram Sang wrote:
> devm_ioremap_resource does sanity checks on the given resource. No need to
> duplicate this in the driver.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Sorry looks like I missed this and instead applied a similar patch from Julia
last week. I should have taken this instead. My bad...

~Vinod
> ---
> Please apply via the subsystem-tree.
>
> drivers/dma/mmp_pdma.c | 3 ---
> drivers/dma/mmp_tdma.c | 3 ---
> 2 files changed, 6 deletions(-)
>
> diff --git a/drivers/dma/mmp_pdma.c b/drivers/dma/mmp_pdma.c
> index c26699f..7eba967 100644
> --- a/drivers/dma/mmp_pdma.c
> +++ b/drivers/dma/mmp_pdma.c
> @@ -778,9 +778,6 @@ static int mmp_pdma_probe(struct platform_device *op)
> pdev->dev = &op->dev;
>
> iores = platform_get_resource(op, IORESOURCE_MEM, 0);
> - if (!iores)
> - return -EINVAL;
> -
> pdev->base = devm_ioremap_resource(pdev->dev, iores);
> if (IS_ERR(pdev->base))
> return PTR_ERR(pdev->base);
> diff --git a/drivers/dma/mmp_tdma.c b/drivers/dma/mmp_tdma.c
> index 9b93665..1f1885a 100644
> --- a/drivers/dma/mmp_tdma.c
> +++ b/drivers/dma/mmp_tdma.c
> @@ -549,9 +549,6 @@ static int mmp_tdma_probe(struct platform_device *pdev)
> }
>
> iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (!iores)
> - return -EINVAL;
> -
> tdev->base = devm_ioremap_resource(&pdev->dev, iores);
> if (IS_ERR(tdev->base))
> return PTR_ERR(tdev->base);
> --
> 1.7.10.4
>

--


\
 
 \ /
  Last update: 2013-08-19 12:01    [W:0.059 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site