lkml.org 
[lkml]   [2013]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 19/34] cpufreq: maple: remove calls to cpufreq_notify_transition()
    Date
    Most of the drivers do following in their ->target_index() routines:

    struct cpufreq_freqs freqs;
    freqs.old = old freq...
    freqs.new = new freq...

    cpufreq_notify_transition(policy, &freqs, CPUFREQ_PRECHANGE);

    /* Change rate here */

    cpufreq_notify_transition(policy, &freqs, CPUFREQ_POSTCHANGE);

    This is replicated over all cpufreq drivers today and there doesn't exists a
    good enough reason why this shouldn't be moved to cpufreq core instead.

    Earlier patches have added support in cpufreq core to do cpufreq notification on
    frequency change, this one removes it from this driver.

    Some related minor cleanups are also done along with it.

    Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
    Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
    ---
    drivers/cpufreq/maple-cpufreq.c | 18 +-----------------
    1 file changed, 1 insertion(+), 17 deletions(-)

    diff --git a/drivers/cpufreq/maple-cpufreq.c b/drivers/cpufreq/maple-cpufreq.c
    index b508147..45db7a2 100644
    --- a/drivers/cpufreq/maple-cpufreq.c
    +++ b/drivers/cpufreq/maple-cpufreq.c
    @@ -69,8 +69,6 @@ static struct cpufreq_frequency_table maple_cpu_freqs[] = {
    */
    static int maple_pmode_cur;

    -static DEFINE_MUTEX(maple_switch_mutex);
    -
    static const u32 *maple_pmode_data;
    static int maple_pmode_max;

    @@ -133,21 +131,7 @@ static int maple_scom_query_freq(void)
    static int maple_cpufreq_target(struct cpufreq_policy *policy,
    unsigned int index)
    {
    - struct cpufreq_freqs freqs;
    - int rc;
    -
    - mutex_lock(&maple_switch_mutex);
    -
    - freqs.old = maple_cpu_freqs[maple_pmode_cur].frequency;
    - freqs.new = maple_cpu_freqs[index].frequency;
    -
    - cpufreq_notify_transition(policy, &freqs, CPUFREQ_PRECHANGE);
    - rc = maple_scom_switch_freq(index);
    - cpufreq_notify_transition(policy, &freqs, CPUFREQ_POSTCHANGE);
    -
    - mutex_unlock(&maple_switch_mutex);
    -
    - return rc;
    + return maple_scom_switch_freq(index);
    }

    static unsigned int maple_cpufreq_get_speed(unsigned int cpu)
    --
    1.7.12.rc2.18.g61b472e


    \
     
     \ /
      Last update: 2013-08-16 05:01    [W:4.087 / U:0.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site