Messages in this thread | | | Subject | Re: [PATCH 35/36] hid: roccat: convert class code to use bin_attrs in groups | From | Stefan Achatz <> | Date | Thu, 15 Aug 2013 18:03:46 +0200 |
| |
Hello Greg, looking through the patch I found the following:
In hid-roccat-kone.c, PROFILE_ATTR macro: The line .private = &profile_numbers[number], should read .private = &profile_numbers[number-1],
Regarding the compiler warning about unused pyra_sysfs_write_settings: The attribute is indeed readwrite, but the code to write is not standard code. The read function was created with the PYRA_SYSFS_R macro and the write function was written manually. Used were both by PYRA_BIN_ATTRIBUTE_RW. In this case I would keep the PYRA_SYSFS_* macros standalone so that the calling code looks like this:
PYRA_SYSFS_W(control, CONTROL); PYRA_SYSFS_RW(info, INFO); PYRA_SYSFS_RW(profile_settings, PROFILE_SETTINGS); PYRA_SYSFS_RW(profile_buttons, PROFILE_BUTTONS); PYRA_SYSFS_R(settings, SETTINGS);
PYRA_BIN_ATTRIBUTE_W(control, CONTROL); PYRA_BIN_ATTRIBUTE_RW(info, INFO); PYRA_BIN_ATTRIBUTE_RW(profile_settings, PROFILE_SETTINGS); PYRA_BIN_ATTRIBUTE_RW(profile_buttons, PROFILE_BUTTONS); PYRA_BIN_ATTRIBUTE_RW(settings, SETTINGS);
Another thing: Why does nobody (besides me) use the get_maintainer.pl script, so I have to search manually for patches regarding my code?
Have a nice day, Stefan
| |