lkml.org 
[lkml]   [2013]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH RESEND 8/8] net: davinci_mdio: use platform_{get,set}_drvdata()

    We can use the wrapper functions platform_{get,set}_drvdata() instead of
    dev_{get,set}_drvdata() with &pdev->dev, it is convenient for user.

    Also, unnecessary dev_set_drvdata() is removed, because the driver core
    clears the driver data to NULL after device_release or on probe failure.


    Signed-off-by: Libo Chen <libo.chen@huawei.com>
    ---
    drivers/net/ethernet/ti/davinci_mdio.c | 4 +---
    1 files changed, 1 insertions(+), 3 deletions(-)

    diff --git a/drivers/net/ethernet/ti/davinci_mdio.c b/drivers/net/ethernet/ti/davinci_mdio.c
    index 16ddfc3..2249b2c 100644
    --- a/drivers/net/ethernet/ti/davinci_mdio.c
    +++ b/drivers/net/ethernet/ti/davinci_mdio.c
    @@ -421,8 +421,7 @@ bail_out:

    static int davinci_mdio_remove(struct platform_device *pdev)
    {
    - struct device *dev = &pdev->dev;
    - struct davinci_mdio_data *data = dev_get_drvdata(dev);
    + struct davinci_mdio_data *data = platform_get_drvdata(pdev);

    if (data->bus) {
    mdiobus_unregister(data->bus);
    @@ -434,7 +433,6 @@ static int davinci_mdio_remove(struct platform_device *pdev)
    pm_runtime_put_sync(&pdev->dev);
    pm_runtime_disable(&pdev->dev);

    - dev_set_drvdata(dev, NULL);

    kfree(data);

    --
    1.7.1




    \
     
     \ /
      Last update: 2013-08-14 06:01    [W:4.726 / U:1.444 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site