lkml.org 
[lkml]   [2013]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3] arm: omap5: dts: add palmas-usb node
    On 08/12/2013 04:17 AM, Kishon Vijay Abraham I wrote:
    > From: Felipe Balbi <balbi@ti.com>
    >
    > Without this node, there will be no palmas
    > driver to notify dwc3 that a cable has
    > been connected and, without that, dwc3
    > will never initialize.

    > diff --git a/arch/arm/boot/dts/omap5-uevm.dts b/arch/arm/boot/dts/omap5-uevm.dts

    > interrupt-controller;
    > #interrupt-cells = <2>;
    >
    > + extcon_usb3: palmas_usb {
    > + compatible = "ti,palmas-usb";

    This isn't so much a comment on this patch as the Palmas binding:

    Presumably, the Palmas device contains a USB VID detector, not a whole
    USB controller. I'd expect the compatible value to indicate this more
    directly, i.e. be something like ti,palmas-usb-vid or
    ti,palmas-usb-vid-detector.


    \
     
     \ /
      Last update: 2013-08-13 01:21    [W:2.258 / U:0.872 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site