Messages in this thread | | | Date | Mon, 12 Aug 2013 14:25:57 -0300 | From | Mauro Carvalho Chehab <> | Subject | Re: [PATCH 3/3] mce: acpi/apei: trace: Enable ghes memory error trace event |
| |
Em Mon, 12 Aug 2013 17:04:24 +0200 Borislav Petkov <bp@alien8.de> escreveu:
> On Mon, Aug 12, 2013 at 11:49:32AM -0300, Mauro Carvalho Chehab wrote: > > Clear win from what PoV? Userspace will need to decode a different type > > of tracing, and implement a different logic for APEI. > > There's no different type of tracing - it is the same info as in both > cases it comes from APEI.
Well, patch 2/3 is defining a different type of tracing for memory errors, instead of re-using the existing one.
> And if it can be done in the APEI layer, then > we don't need the next layer.
Userspace still needs the EDAC sysfs, in order to identify how the memory is organized, and do the proper memory labels association.
What edac_ghes does is to fill those sysfs nodes, and to call the existing tracing to report errors.
> > Also, if both ghes_edac and this new tracing is enabled, userspace > > will receive twice the same event, as two traces will be received for > > the same thing. > > We are, of course, going to have only one tracepoint which reports > memory errors, not two.
Yes, that's my point.
Regards, Mauro
| |