lkml.org 
[lkml]   [2013]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 8/16] arch/arm/mach-pxa/palmz72.c: Avoid using ARRAY_AND_SIZE(e) as a function argument
Date
From: Julia Lawall <Julia.Lawall@lip6.fr>

Replace ARRAY_AND_SIZE(e) in function argument position to avoid hiding the
arity of the called function.

The semantic match that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e,f;
@@

f(...,
- ARRAY_AND_SIZE(e)
+ e,ARRAY_SIZE(e)
,...)
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
Not compiled.

arch/arm/mach-pxa/palmz72.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-pxa/palmz72.c b/arch/arm/mach-pxa/palmz72.c
index 1a35ddf..5f8fd00 100644
--- a/arch/arm/mach-pxa/palmz72.c
+++ b/arch/arm/mach-pxa/palmz72.c
@@ -356,9 +356,11 @@ static inline void __init palmz72_cam_gpio_init(void)
{
int ret;

- ret = gpio_request_array(ARRAY_AND_SIZE(palmz72_camera_gpios));
+ ret = gpio_request_array(palmz72_camera_gpios,
+ ARRAY_SIZE(palmz72_camera_gpios));
if (!ret)
- gpio_free_array(ARRAY_AND_SIZE(palmz72_camera_gpios));
+ gpio_free_array(palmz72_camera_gpios,
+ ARRAY_SIZE(palmz72_camera_gpios));
else
printk(KERN_ERR "Camera GPIO init failed!\n");

@@ -381,7 +383,7 @@ static inline void palmz72_camera_init(void) {}
******************************************************************************/
static void __init palmz72_init(void)
{
- pxa2xx_mfp_config(ARRAY_AND_SIZE(palmz72_pin_config));
+ pxa2xx_mfp_config(palmz72_pin_config, ARRAY_SIZE(palmz72_pin_config));
pxa_set_ffuart_info(NULL);
pxa_set_btuart_info(NULL);
pxa_set_stuart_info(NULL);


\
 
 \ /
  Last update: 2013-08-11 19:21    [W:0.185 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site