lkml.org 
[lkml]   [2013]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] kvm tools: Fix build of guest init with biarch powerpc compilers
From
On Wed, Aug 7, 2013 at 11:46 AM, Michael Ellerman
<michael@ellerman.id.au> wrote:
> On powerpc we build kvmtool as a 64bit binary. We do that by setting
> -m64 in our CFLAGS. For most things we just call $(CC) and it passes
> that info onto the linker.
>
> However there is one place where we explicitly call the linker, in the
> build of guest/init - and in that case we need to tell the linker to
> build 64bit.
>
> We have gotten away with this so far because we have been building with
> a 64bit only toolchain. However if you build with a biarch toolchain,
> which generally defaults to 32bit, we fail to link.
>
> The fix is to defined LDFLAGS appropriately and pass it to LD.
>
> Tested on powerpc and x86-64.
>
> Signed-off-by: Michael Ellerman <michael@ellerman.id.au>

Applied, thanks a lot!


\
 
 \ /
  Last update: 2013-08-10 09:21    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog