lkml.org 
[lkml]   [2013]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/7] powerpc/perf: Define big-endian version of perf_mem_data_src
On Sat, 10 Aug 2013, Sukadev Bhattiprolu wrote:

>
> include/uapi/linux/perf_event.h | 55 +++++++++++++++++++++++++++++++++++++++
> 1 files changed, 55 insertions(+), 0 deletions(-)

> +#define __PERF_LE 1234
> +#define __PERF_BE 4321
> +
> +#if defined(__KERNEL__)

I could be wrong, but I thought files under uapi weren't supposed to
contain __KERNEL__ code. Wasn't that the whole point of uapi?

Also having the perf_event interface depend on endianess just seems like a
complicated mess. Can't we just declare the interface to be a certain
endianess and have the kernel byte-swap as necessary?

Vince


\
 
 \ /
  Last update: 2013-08-11 04:41    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog