lkml.org 
[lkml]   [2013]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] staging/lustre: lloop depends on BLOCK
On Fri, Aug 02, 2013 at 10:20:28AM +0800, Xiong Zhou wrote:
>
>
> On Wed, 31 Jul 2013, Greg Kroah-Hartman wrote:
>
> > On Wed, Jul 31, 2013 at 10:30:41AM +0800, Xiong Zhou wrote:
> > > From: Xiong Zhou <jencce.kernel@gmail.com>
> > >
> > > First version of this patch makes LUSTRE_FS depends on BLOCK. Second
> > > version makes only lloop depends on BLOCK with a config option for this
> > > dependence, and remove unnecessary jdb header files which depends on
> > > BLOCK.
> > >
> > > This version removes the wrapper ll_unregister_blkdev which depends on
> > > BLOCK in header and just call unregister_blkdev in lloop.c based on Peng
> > > Tao's comment.
> >
> > This isn't all needed in the patch changelog info, just say what it
> > does.
> >
> > Also, it doesn't apply for some reason, care to refresh this against my
> > latest tree and resend?
> >
> > thanks,
> >
> > greg k-h
> >
>
> OK, this patch is based on the staging-next branch of your staging tree.
>
>
> From: Xiong Zhou <jencce.kernel@gmail.com>
>
> Add a config option for llite/lloop in lustre driver, making it
> depends on BLOCK to fix this better:
> drivers/staging/lustre/lustre/fid/../include/linux/lustre_compat25.h:117:2:
> error: implicit declaration of function ‘unregister_blkdev’
>
> Also, remove the wrapper ll_unregister_blkdev which depends on BLOCK in
> the header and just call unregister_blkdev in lloop.c based on Peng Tao's
> comment. Drop the redundant dependency on STAGING for LUSTRE_FS, remove
> some unnecessary jdb header files which depends on BLOCK btw.
>
> Signed-off-by: Xiong Zhou <jencce.kernel@gmail.com>
> Reviewed-by: Peng Tao <tao.peng@emc.com>

Please resend this so I don't have to edit the body of the email, and
the Subject: line as well.

Also, you have a bunch of trailing whitespace in your changelog
comments, are you sure you want/need that?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-08-02 05:41    [W:2.368 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site