Messages in this thread | | | Date | Thu, 1 Aug 2013 16:19:19 +0200 | From | Frederic Weisbecker <> | Subject | Re: [PATCH 6/8] perf: Account freq events per cpu |
| |
On Thu, Aug 01, 2013 at 04:03:52PM +0200, Peter Zijlstra wrote: > On Thu, Aug 01, 2013 at 03:55:27PM +0200, Frederic Weisbecker wrote: > > On Thu, Aug 01, 2013 at 03:31:55PM +0200, Peter Zijlstra wrote: > > > > > > Where the freq thing is new and shiney, but we already had the other > > > two. Of those, cgroup events must be per cpu so that should be good, > > > the branch_stack thing tests ATTACH_TASK, which should also be good, but > > > leaves me wonder wth they do for those that are attached to tasks. > > > > > > But yes, the frequency thing is borken. > > > > Aie, so the freq thing, I can either account to all CPUs (inc to all > > and send an IPI to all), or when the event scheds in/out. Probably we > > should do the former to avoid sending an IPI at all context switches. > > Yeah, just go with a single global state for now..
A single global counter? Ok sounds good.
| |