Messages in this thread | | | Date | Thu, 1 Aug 2013 16:50:56 +0100 | From | Richard Fitzgerald <> | Subject | Re: [PATCH] ASoC: core: init delayed_work for codec-codec links |
| |
On Thu, Aug 01, 2013 at 04:23:56PM +0100, Mark Brown wrote: > On Thu, Aug 01, 2013 at 04:13:52PM +0100, Richard Fitzgerald wrote: > > On Wed, Jul 31, 2013 at 02:25:22PM +0100, Mark Brown wrote: > > > > Why is this better than pointing at the normal work that you'd expect to > > > be used there? > > > By 'normal work' do you mean the close_delayed_work() used for > > standard PCM DAIs? > > Yes - making up this empty work doesn't seem like a robust approach.
Yeah, I think the problem is more one of bad naming. I should define that function as the delayed work for codec-2-codec links, it just happens that we don't currently have to do anything for them. The only thing the pcm close_delayed_work() does is to send a SND_SOC_DAPM_STREAM_STOP but for c2c links we never send a start anyway.
| |