Messages in this thread Patch in this message | | | Subject | [PATCH] regulator: pfuze100: Fix off-by-one for max_register setting | From | Axel Lin <> | Date | Thu, 01 Aug 2013 19:59:56 +0800 |
| |
max_register should be register count - 1.
Signed-off-by: Axel Lin <axel.lin@ingics.com> --- Hi Robin, I don't have the datasheet, can you check if this patch is correct or not? If PFUZE_NUMREGS really means register count, I think this fix is required.
Thanks, Axel drivers/regulator/pfuze100-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/pfuze100-regulator.c b/drivers/regulator/pfuze100-regulator.c index bda5561..ba67b2c 100644 --- a/drivers/regulator/pfuze100-regulator.c +++ b/drivers/regulator/pfuze100-regulator.c @@ -332,7 +332,7 @@ static int pfuze_identify(struct pfuze_chip *pfuze_chip) static const struct regmap_config pfuze_regmap_config = { .reg_bits = 8, .val_bits = 8, - .max_register = PFUZE_NUMREGS, + .max_register = PFUZE_NUMREGS - 1, .cache_type = REGCACHE_RBTREE, }; -- 1.8.1.2
| |