Messages in this thread | | | Date | Tue, 9 Jul 2013 10:12:00 +0300 | From | Ferruh Yigit <> | Subject | Re: Input: cyttsp4 - SPI driver for Cypress TMA4XX touchscreen devices |
| |
On 07/07/2013 10:15 PM, Geert Uytterhoeven wrote: > On Fri, Jul 5, 2013 at 1:51 AM, Linux Kernel Mailing List > <linux-kernel@vger.kernel.org> wrote: >> +++ b/drivers/input/touchscreen/cyttsp4_spi.c > >> +static int cyttsp_spi_xfer(struct device *dev, u8 *xfer_buf, >> + u8 op, u8 reg, u8 *buf, int length) >> +{ > >> + if (reg > 255) > > As "reg" is "u8", this is never true: > > drivers/input/touchscreen/cyttsp4_spi.c: In function ‘cyttsp_spi_xfer’: > drivers/input/touchscreen/cyttsp4_spi.c:66: warning: comparison is > always false due to limited range of data type > >> + wr_buf[0] = op + CY_SPI_A8_BIT; >> + else >> + wr_buf[0] = op; > > Can the if-clause and the first branch just be removed, or is there a real bug > involved (e.g. wrong type for "reg")?
Yes there was a bug here, and already sent a patch for this, please check https://patchwork.kernel.org/patch/2820561/
thanks, ferruh
This message and any attachments may contain Cypress (or its subsidiaries) confidential information. If it has been received in error, please advise the sender and immediately delete this message. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |