Messages in this thread | | | From | Jiri Olsa <> | Subject | [RFC 0/4] perf tools: Remove event types data | Date | Tue, 9 Jul 2013 18:48:55 +0200 |
| |
hi, following up on the 'perf timechart' FIXME note and changing its tracepoint match not to use event types data.
In my tests the old and new timechart outputs look the same, so.. any other tester would be appreciated ;-)
Also as this was the only user of the event types data the rest of the patchset is removing it out of the perf.
The event types data are referenced from the perf data file header. The reference (offset & size) stays in the header with 0s.
Also the event types data is already duplicated via the event_desc FEATURE, so there's no information loss.
thanks for comments, jirka
Signed-off-by: Jiri Olsa <jolsa@redhat.com> Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Cc: Ingo Molnar <mingo@elte.hu> Cc: Paul Mackerras <paulus@samba.org> Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: David Ahern <dsahern@gmail.com> Cc: Thomas Renninger <trenn@suse.de> --- tools/perf/builtin-inject.c | 7 ------ tools/perf/builtin-record.c | 13 ----------- tools/perf/builtin-report.c | 1 - tools/perf/builtin-script.c | 1 - tools/perf/builtin-timechart.c | 94 ++++++++++++++++++++++++++++++++++++++++++------------------------------------- tools/perf/util/event.h | 2 +- tools/perf/util/header.c | 118 +--------------------------------------------------------------------------------------------------- tools/perf/util/header.h | 16 +------------- tools/perf/util/session.c | 11 ---------- tools/perf/util/tool.h | 3 --- 10 files changed, 54 insertions(+), 212 deletions(-)
| |