Messages in this thread | | | Date | Tue, 09 Jul 2013 11:34:00 +0100 | From | Srinivas KANDAGATLA <> | Subject | Re: [PATCH v1 0/4] ARM: STi fixes and ethernet support |
| |
On 09/07/13 08:56, Arnd Bergmann wrote: > No, you should be using generic interfaces to do the things you need. > > I believe what you are missing is an ethernet phy driver that is specific > to your SoC. It looks interesting way to solve the issue.
Did you mean "Ethernet PHY"?
Ethernet PHY is not integrated in the STiH41x SoC, We use an external ICPLUS phy ( drivers/net/phy/icplus.c) for both B2000 and B2020 boards. As we can't have two Ethernet phy drivers at the same time, I think the suggestion might not work in this case.
The callbacks in the mach level are setting up two SOC specific System Configuration registers which configures the MAC (like PHY interface selection, which is sampled during MAC reset assertion).
MAC used in STiH41x supports multiple PHY interfaces, so the PHY interface selection is driven by external signals wired up to System Configuration registers. The MAC driver is not aware of these System Configuration registers. So for non-DT case, stmmac driver provided callbacks to do things like this.
For DT case, At the moment I think callbacks at MACH level is one possible solution. But am open for any discussions.
Thanks, srini
> > Arnd
| |