lkml.org 
[lkml]   [2013]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [v9fs:for-linus 7/7] ERROR: code indent should use tabs where possible
> > > TRAILING_STATEMENTS
> >
> > False positives? Got an example?
>
> tree: git://git.freedesktop.org/git/nouveau/linux-2.6 drm-nouveau-next
> head: d2989b534ef6834ebf2425aecc040b894b567c91
> commit: 01672ef454307bf63e93defb3599399b678ff58b [3/68] drm/nve0/fifo: copy engine context stored in ramfc, not externally
>
> ERROR: trailing statements should be on next line
> #28: FILE: drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c:146:
> + case NVDEV_ENGINE_GR : addr = 0x0210; break;
>
> ERROR: trailing statements should be on next line
> #40: FILE: drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c:183:
> + case NVDEV_ENGINE_COPY2: addr = 0x0000; break;
>
> ERROR: trailing statements should be on next line
> #41: FILE: drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c:184:
> + case NVDEV_ENGINE_GR : addr = 0x0210; break;

In this case the code does look neat:

switch (nv_engidx(object->engine)) {
case NVDEV_ENGINE_SW : return 0;
- case NVDEV_ENGINE_GR :
case NVDEV_ENGINE_COPY0:
- case NVDEV_ENGINE_COPY1: addr = 0x0210; break;
+ case NVDEV_ENGINE_COPY1:
+ case NVDEV_ENGINE_COPY2: addr = 0x0000; break;
+ case NVDEV_ENGINE_GR : addr = 0x0210; break;
case NVDEV_ENGINE_BSP : addr = 0x0270; break;
case NVDEV_ENGINE_VP : addr = 0x0250; break;
case NVDEV_ENGINE_PPP : addr = 0x0260; break;

Thanks,
Fengguang


\
 
 \ /
  Last update: 2013-07-10 23:04    [W:0.062 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site