Messages in this thread | | | Date | Mon, 8 Jul 2013 12:57:27 +0800 | From | Fengguang Wu <> | Subject | Re: [v9fs:for-linus 7/7] ERROR: code indent should use tabs where possible |
| |
On Mon, Jul 08, 2013 at 12:47:47PM +0800, Fengguang Wu wrote: > > > > TRAILING_STATEMENTS > > > > > > False positives? Got an example? > > > > tree: git://git.freedesktop.org/git/nouveau/linux-2.6 drm-nouveau-next > > head: d2989b534ef6834ebf2425aecc040b894b567c91 > > commit: 01672ef454307bf63e93defb3599399b678ff58b [3/68] drm/nve0/fifo: copy engine context stored in ramfc, not externally > > > > ERROR: trailing statements should be on next line > > #28: FILE: drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c:146: > > + case NVDEV_ENGINE_GR : addr = 0x0210; break; > > > > ERROR: trailing statements should be on next line > > #40: FILE: drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c:183: > > + case NVDEV_ENGINE_COPY2: addr = 0x0000; break; > > > > ERROR: trailing statements should be on next line > > #41: FILE: drivers/gpu/drm/nouveau/core/engine/fifo/nve0.c:184: > > + case NVDEV_ENGINE_GR : addr = 0x0210; break; > > In this case the code does look neat: > > switch (nv_engidx(object->engine)) { > case NVDEV_ENGINE_SW : return 0; > - case NVDEV_ENGINE_GR : > case NVDEV_ENGINE_COPY0: > - case NVDEV_ENGINE_COPY1: addr = 0x0210; break; > + case NVDEV_ENGINE_COPY1: > + case NVDEV_ENGINE_COPY2: addr = 0x0000; break; > + case NVDEV_ENGINE_GR : addr = 0x0210; break; > case NVDEV_ENGINE_BSP : addr = 0x0270; break; > case NVDEV_ENGINE_VP : addr = 0x0250; break; > case NVDEV_ENGINE_PPP : addr = 0x0260; break;
It's actually a common case.
git grep ';.*;$' -- '*.c' | grep -o '\S*$' | sort | uniq -c | sort -nr | head
==> 4156 break; 465 return;); 273 -1;); 158 0; 146 mdelay(1); 143 eieio(); 140 msleep(1); 135 4; 94 ; 93 8;
Thanks, Fengguang
| |