Messages in this thread | | | Date | Mon, 8 Jul 2013 10:01:25 +0800 | From | Bo Shen <> | Subject | Re: [RFC PATCH 08/13] sound: sam9x5_wm8731: machine driver for at91sam9x5 wm8731 boards |
| |
Hi Richard,
On 7/5/2013 23:15, Richard Genoud wrote: >>> + card->dev = &pdev->dev; >>> >>+ card->owner = THIS_MODULE; >>> >>+ card->dai_link = dai; >>> >>+ card->num_links = 1; >>> >>+ dai->name = "WM8731"; >>> >>+ dai->stream_name = "WM8731 PCM"; >>> >>+ dai->codec_dai_name = "wm8731-hifi"; >>> >>+ dai->init = at91sam9x5ek_wm8731_init; >>> >>+ card->dapm_widgets = at91sam9x5ek_dapm_widgets; >>> >>+ card->num_dapm_widgets = ARRAY_SIZE(at91sam9x5ek_dapm_widgets); >> > >> > >> >Will keep these as snd_soc_card and snd_soc_dai_link structure separately? > I don't really understand what you mean here. > do you mean that something like that will more explicit ? : > + card->dai_link[0].name = "WM8731"; > + card->dai_link[0].stream_name = "WM8731 PCM"; > + card->dai_link[0].codec_dai_name = "wm8731-hifi"; > + card->dai_link[0].init = at91sam9x5ek_wm8731_init; >
I mean using structure to define snd_soc_card and snd_soc_dai_link, look like: struct snd_soc_dai_link dai_link_name = { .name = xxx, .stream_name = xxx, ... };
struct snd_soc_card card_name = { .name = xxxx .ower = THIS_MODULE, .dai_link = &dai_link_name, ... };
In this way, I think it will be more clear than put them in code.
Best Regards, Bo Shen
| |